nsivabalan commented on code in PR #9630:
URL: https://github.com/apache/hudi/pull/9630#discussion_r1409728826


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1540,13 +1510,18 @@ private HoodieData<HoodieRecord> 
getRecordIndexUpdates(HoodieData<WriteStatus> w
                   recordDelegate.getRecordKey(), 
recordDelegate.getPartitionPath(),
                   newLocation.get().getFileId(), 
newLocation.get().getInstantTime(), dataWriteConfig.getWritesFileIdEncoding());
             }
+            hoodieRecord = HoodieMetadataPayload.createRecordIndexUpdate(

Review Comment:
   this does not look right. 
   we should not add a entry to RLI metadata partition if it is an update 
record in data table. 
   as per master, we will ignore it. but here looks like we are updating RLI 
even for update record. 
   can you double check the logic once. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to