TengHuo commented on code in PR #8503:
URL: https://github.com/apache/hudi/pull/8503#discussion_r1412233347


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/bucket/HoodieSparkConsistentBucketIndex.java:
##########
@@ -189,29 +195,64 @@ public HoodieConsistentHashingMetadata 
loadOrCreateMetadata(HoodieTable table, S
    */
   public static Option<HoodieConsistentHashingMetadata> 
loadMetadata(HoodieTable table, String partition) {
     Path metadataPath = 
FSUtils.getPartitionPath(table.getMetaClient().getHashingMetadataPath(), 
partition);
-
+    Path partitionPath = 
FSUtils.getPartitionPath(table.getMetaClient().getBasePathV2(), partition);

Review Comment:
   Yeah, correct, the marker file is under data partition. So, as I understand, 
`commitMetaTss` will always be an empty set. Because `metaFiles` is not data 
partition, it is `FSUtils.getPartitionPath(metaClient.getHashingMetadataPath(), 
partition)`.
   
   ```
   final TreeSet<String> commitMetaTss = 
Arrays.stream(metaFiles).filter(hashingMetaCommitFilePredicate)
   ```
   
   May I ask how the recovery consistency works? Which part of code I should 
refer? Really appreciate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to