danny0405 commented on code in PR #10230:
URL: https://github.com/apache/hudi/pull/10230#discussion_r1413310224
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/TestStreamWriteOperatorCoordinator.java:
##########
@@ -185,6 +188,41 @@ public void testRecommitWithPartialUncommittedEvents() {
assertThat("Recommits the instant with partial uncommitted events",
lastCompleted, is(instant));
}
+ @Test
+ public void testStopHeartbeatForUncommittedEventWithLazyCleanPolicy() throws
Exception {
+ // reset
+ reset();
+ // override the default configuration
+ Configuration conf =
TestConfigurations.getDefaultConf(tempFile.getAbsolutePath());
+ OperatorCoordinator.Context context = new
MockOperatorCoordinatorContext(new OperatorID(), 1);
+ coordinator = new StreamWriteOperatorCoordinator(conf, context);
+ coordinator.start();
+ coordinator.setExecutor(new MockCoordinatorExecutor(context));
+
+ coordinator.getWriteClient().getConfig()
+ .setValue(HoodieCleanConfig.FAILED_WRITES_CLEANER_POLICY,
HoodieFailedWritesCleaningPolicy.LAZY.name());
+
assertTrue(coordinator.getWriteClient().getConfig().getFailedWritesCleanPolicy().isLazy());
+
+ final WriteMetadataEvent event0 = WriteMetadataEvent.emptyBootstrap(0);
+
+ // start one instant and not commit it
+ coordinator.handleEventFromOperator(0, event0);
+ String instant = coordinator.getInstant();
+ HoodieHeartbeatClient heartbeatClient =
coordinator.getWriteClient().getHeartbeatClient();
+ assertNotEquals(null, heartbeatClient.getHeartbeat(instant), "Heartbeat
should not null");
+
Review Comment:
Use `assertNotNull`? And with better msg prompt: `Heartbeat is missing`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
