pratyakshsharma commented on pull request #1816:
URL: https://github.com/apache/hudi/pull/1816#issuecomment-662962138


   > @pratyakshsharma Thanks for the updates and sorry for late response. For 
users not using latest master, they still need use NonpartitionedKeyGenerator, 
so I think it is valuable to mention it.
   
   In that case, we should mention about existing solutions for other key 
generation cases as well like SimpleKeyGenerator, ComplexKeyGenerator etc. I 
was thinking once CustomKeyGenerator gets released as part of 0.6.0 release, 
then we could mention this in docs something like - 
   
   "For those using Hudi versions older than 0.6.0, you can use the following 
key generators - 
   
   1. Simple record key and custom timestamp based partition path - 
TimestampBasedKeyGenerator
   2. Composite record keys and composite partition paths - ComplexKeyGenerator
   3. Non partitioned table - NonpartitionedKeyGenerator"
   
   Let me know your thoughts on this @leesf 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to