yihua commented on code in PR #10251:
URL: https://github.com/apache/hudi/pull/10251#discussion_r1417891763
##########
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java:
##########
@@ -244,8 +245,9 @@ public Map<Pair<String, String>, HoodieMetadataColumnStats>
getColumnStats(final
Set<String> columnStatKeyset = new HashSet<>();
final ColumnIndexID columnIndexID = new ColumnIndexID(columnName);
for (Pair<String, String> partitionNameFileNamePair :
partitionNameFileNameList) {
+ String partitionIdentifier =
HoodieTableMetadataUtil.getPartitionIdentifier(partitionNameFileNamePair.getLeft());
final String columnStatsIndexKey =
HoodieMetadataPayload.getColumnStatsIndexKey(
- new PartitionIndexID(partitionNameFileNamePair.getLeft()),
+ new PartitionIndexID(partitionIdentifier),
Review Comment:
Can we somehow abstract this for all metadata type so that only one place
calls `HoodieTableMetadataUtil#getPartitionIdentifier` with the actual storage
partition path? When adding a new metadata type in the future, this can be
again forgotten or not implemented correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
