nsivabalan commented on code in PR #10280:
URL: https://github.com/apache/hudi/pull/10280#discussion_r1419962937
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java:
##########
@@ -285,6 +285,7 @@ protected HoodieWriteMetadata<HoodieData<WriteStatus>>
executeClustering(HoodieC
writeMetadata.setPartitionToReplaceFileIds(getPartitionToReplacedFileIds(clusteringPlan,
writeMetadata));
commitOnAutoCommit(writeMetadata);
if (!writeMetadata.getCommitMetadata().isPresent()) {
+ LOG.info("empty commit metadata found for instant " + instantTime);
Review Comment:
Lets give some love towards log statements.
"Found empty commit metadata for clustering with instant time " +
instantTime
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java:
##########
@@ -131,6 +131,14 @@ public HoodieTimeline
filterCompletedAndCompactionInstants() {
|| s.getAction().equals(HoodieTimeline.COMPACTION_ACTION)),
details);
}
+ @Override
+ public HoodieTimeline filterCompactionInstants() {
Review Comment:
filterCompletedCompactionInstants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
