danny0405 commented on code in PR #10295:
URL: https://github.com/apache/hudi/pull/10295#discussion_r1421970338
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -356,7 +356,22 @@ private List<MergeOnReadInputSplit> getIncInputSplits(
LOG.warn("No partitions found for reading under path: " + path);
return Collections.emptyList();
}
- FileStatus[] fileStatuses = WriteProfiles.getFilesFromMetadata(path,
hadoopConf, metadataList, metaClient.getTableType());
+ final FileStatus[] fileStatuses;
+ Boolean skipNotExistsFile =
conf.getBoolean(FlinkOptions.READ_STREAMING_SKIP_NOT_EXIST_FILE);
+ if (!skipNotExistsFile) {
+ LOG.warn("Allow to skip not exists file, fall back to full table scan.");
Review Comment:
Why fallback to full table scan without checking the file existence?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]