yihua commented on code in PR #10263: URL: https://github.com/apache/hudi/pull/10263#discussion_r1423390827
########## hudi-common/src/test/java/org/apache/hudi/common/testutils/reader/DataGenerationPlan.java: ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.common.testutils.reader; + +import java.util.List; + +/** + * The blueprint of records that will be generated + * by the data generator. + * + * Current limitations: + * 1. One plan generates one file, either a base file, or a log file. + * 2. One file contains one operation, e.g., insert, delete, or update. + */ +public class DataGenerationPlan { Review Comment: Is this going to be integrated with `HoodieTestTable` or similar to generate test tables without using transactional writes? ########## hudi-common/src/test/java/org/apache/hudi/common/testutils/reader/HoodieTestReaderContext.java: ########## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.common.testutils.reader; + +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.common.engine.HoodieReaderContext; +import org.apache.hudi.common.fs.FSUtils; +import org.apache.hudi.common.model.HoodieAvroIndexedRecord; +import org.apache.hudi.common.model.HoodieAvroRecordMerger; +import org.apache.hudi.common.model.HoodieEmptyRecord; +import org.apache.hudi.common.model.HoodieKey; +import org.apache.hudi.common.model.HoodieOperation; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.model.HoodieRecordMerger; +import org.apache.hudi.common.util.ConfigUtils; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.common.util.collection.ClosableIterator; +import org.apache.hudi.exception.HoodieException; +import org.apache.hudi.io.storage.HoodieAvroParquetReader; + +import org.apache.avro.Schema; +import org.apache.avro.generic.GenericRecordBuilder; +import org.apache.avro.generic.IndexedRecord; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; + +import java.io.IOException; +import java.util.Map; +import java.util.function.UnaryOperator; + +import static org.apache.hudi.common.model.HoodieRecordMerger.DEFAULT_MERGER_STRATEGY_UUID; +import static org.apache.hudi.common.testutils.reader.HoodieFileSliceTestUtils.ROW_KEY; + +public class HoodieTestReaderContext extends HoodieReaderContext<IndexedRecord> { + @Override + public FileSystem getFs(String path, Configuration conf) { + return FSUtils.getFs(path, conf); + } + + @Override + public ClosableIterator<IndexedRecord> getFileRecordIterator( + Path filePath, + long start, + long length, + Schema dataSchema, + Schema requiredSchema, + Configuration conf + ) throws IOException { + HoodieAvroParquetReader reader = new HoodieAvroParquetReader(conf, filePath); + return reader.getIndexedRecordIterator(dataSchema, requiredSchema); + } + + @Override + public IndexedRecord convertAvroRecord(IndexedRecord record) { + return record; + } + + @Override + public HoodieRecordMerger getRecordMerger(String mergerStrategy) { + switch (mergerStrategy) { + case DEFAULT_MERGER_STRATEGY_UUID: + return new HoodieAvroRecordMerger(); + default: + throw new HoodieException( + "The merger strategy UUID is not supported: " + mergerStrategy); + } + } + + @Override + public Object getValue(IndexedRecord record, Schema schema, String fieldName) { + return getFieldValueFromIndexedRecord(record, schema, fieldName); + } + + @Override + public String getRecordKey(IndexedRecord record, Schema schema) { + return getFieldValueFromIndexedRecord(record, schema, ROW_KEY).toString(); + } + + @Override + public Comparable getOrderingValue( + Option<IndexedRecord> recordOpt, + Map<String, Object> metadataMap, + Schema schema, + TypedProperties props + ) { + if (metadataMap.containsKey(INTERNAL_META_ORDERING_FIELD)) { + return (Comparable) metadataMap.get(INTERNAL_META_ORDERING_FIELD); + } + + if (!recordOpt.isPresent()) { + return 0; + } + + String orderingFieldName = ConfigUtils.getOrderingField(props); + Object value = getFieldValueFromIndexedRecord(recordOpt.get(), schema, orderingFieldName); + return value != null ? (Comparable) value : 0; + } + + @Override + public HoodieRecord<IndexedRecord> constructHoodieRecord( + Option<IndexedRecord> recordOpt, + Map<String, Object> metadataMap + ) { + if (!recordOpt.isPresent()) { + HoodieKey key = new HoodieKey((String) metadataMap.get(INTERNAL_META_RECORD_KEY), + (String) metadataMap.get(INTERNAL_META_PARTITION_PATH)); + return new HoodieEmptyRecord<>( + key, + HoodieOperation.DELETE, + (Comparable<?>) metadataMap.get(INTERNAL_META_ORDERING_FIELD), + HoodieRecord.HoodieRecordType.AVRO); + } + return new HoodieAvroIndexedRecord(recordOpt.get()); + } + + @Override + public IndexedRecord seal(IndexedRecord record) { + Schema schema = record.getSchema(); + GenericRecordBuilder builder = new GenericRecordBuilder(schema); + for (Schema.Field field : schema.getFields()) { + builder.set(field, record.get(field.pos())); + } + return builder.build(); + } + + @Override + public ClosableIterator<IndexedRecord> mergeBootstrapReaders(ClosableIterator<IndexedRecord> skeletonFileIterator, ClosableIterator<IndexedRecord> dataFileIterator) { + return null; + } + + @Override + public UnaryOperator<IndexedRecord> projectRecord(Schema from, Schema to) { + return null; + } Review Comment: Is this going to be implemented in a separate PR? ########## hudi-common/src/test/java/org/apache/hudi/common/testutils/reader/HoodieFileSliceTestUtils.java: ########## @@ -0,0 +1,440 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.common.testutils.reader; + +import org.apache.hudi.avro.HoodieAvroWriteSupport; +import org.apache.hudi.common.bloom.BloomFilter; +import org.apache.hudi.common.bloom.BloomFilterFactory; +import org.apache.hudi.common.bloom.BloomFilterTypeCode; +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.common.engine.LocalTaskContextSupplier; +import org.apache.hudi.common.model.DeleteRecord; +import org.apache.hudi.common.model.FileSlice; +import org.apache.hudi.common.model.HoodieAvroIndexedRecord; +import org.apache.hudi.common.model.HoodieBaseFile; +import org.apache.hudi.common.model.HoodieFileGroupId; +import org.apache.hudi.common.model.HoodieKey; +import org.apache.hudi.common.model.HoodieLogFile; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.table.log.HoodieLogFormat; +import org.apache.hudi.common.table.log.block.HoodieAvroDataBlock; +import org.apache.hudi.common.table.log.block.HoodieCDCDataBlock; +import org.apache.hudi.common.table.log.block.HoodieDataBlock; +import org.apache.hudi.common.table.log.block.HoodieDeleteBlock; +import org.apache.hudi.common.table.log.block.HoodieHFileDataBlock; +import org.apache.hudi.common.table.log.block.HoodieLogBlock; +import org.apache.hudi.common.table.log.block.HoodieParquetDataBlock; +import org.apache.hudi.common.testutils.HoodieTestDataGenerator; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.common.util.collection.Pair; +import org.apache.hudi.io.storage.HoodieAvroParquetWriter; +import org.apache.hudi.io.storage.HoodieParquetConfig; + +import org.apache.avro.Schema; +import org.apache.avro.generic.IndexedRecord; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hbase.io.compress.Compression; +import org.apache.parquet.avro.AvroSchemaConverter; +import org.apache.parquet.hadoop.ParquetWriter; +import org.apache.parquet.hadoop.metadata.CompressionCodecName; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Properties; +import java.util.UUID; +import java.util.stream.Collectors; +import java.util.stream.IntStream; + +import static org.apache.hudi.common.table.log.block.HoodieLogBlock.HoodieLogBlockType.DELETE_BLOCK; +import static org.apache.hudi.common.table.log.block.HoodieLogBlock.HoodieLogBlockType.PARQUET_DATA_BLOCK; +import static org.apache.hudi.common.testutils.FileCreateUtils.baseFileName; +import static org.apache.hudi.common.testutils.FileCreateUtils.logFileName; +import static org.apache.hudi.common.testutils.HoodieTestDataGenerator.AVRO_SCHEMA; +import static org.apache.hudi.common.testutils.reader.DataGenerationPlan.OperationType.DELETE; +import static org.apache.hudi.common.testutils.reader.DataGenerationPlan.OperationType.INSERT; + +public class HoodieFileSliceTestUtils { Review Comment: Should this be part of `HoodieTestTable` instead of utils class/methods so one can easily write a Hudi table on storage for testing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
