danny0405 commented on code in PR #10297:
URL: https://github.com/apache/hudi/pull/10297#discussion_r1423550203
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -508,10 +509,7 @@ protected void doWrite(HoodieRecord record, Schema schema,
TypedProperties props
flushToDiskIfRequired(record, false);
writeToBuffer(record);
} catch (Throwable t) {
- // Not throwing exception from here, since we don't want to fail the
entire job
- // for a single record
- writeStatus.markFailure(record, t, recordMetadata);
- LOG.error("Error writing record " + record, t);
+ throw new HoodieInsertException("Error writing record " + record, t);
Review Comment:
Does Spark have similiar option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
