linliu-code commented on code in PR #10286:
URL: https://github.com/apache/hudi/pull/10286#discussion_r1424510797
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieAvroRecordMerger.java:
##########
@@ -59,6 +59,13 @@ private Option<IndexedRecord>
combineAndGetUpdateValue(HoodieRecord older, Hoodi
return Option.empty();
}
+ if (newer.isDelete(schema, props)) {
+ if (newer.getOrderingValue(schema,
props).compareTo(older.getOrderingValue(schema, props)) >= 0) {
+ return Option.empty();
Review Comment:
My rough idea is that if we are going to remove all kinds of payload
classes, then we should start to move these logics bit by bit. I will document
this idea somewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
