xushiyan opened a new pull request, #10321:
URL: https://github.com/apache/hudi/pull/10321

   ### Change Logs
   
   `lastVersionBeforeEarliestCommitToRetain` is not honored by 
`KEEP_LATEST_BY_HOURS` policy. This essentially makes cleaner to remove an 
eligible file slice when it becomes non-latest. This could fail long-running 
queries in a race condition:
   
   1. timeline contains a t0.deltacommit (not cleaned because it's latest)
   2. a snapshot query starts and running
   3. compaction runs and creates t1.commit
   4. cleaner runs and remove t0 (because now t1.commit is the latest)
   5. the query failed due to a log file belongs to t0.deltacommit is not found
   
   ### Impact
   
   Make cleaner logic more robust when use clean by hour policy.
   
   ### Risk level
   
   Low.
   
   ### Documentation Update
   
   NA
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to