yihua commented on code in PR #10304:
URL: https://github.com/apache/hudi/pull/10304#discussion_r1424808466
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieHadoopFsRelationFactory.scala:
##########
@@ -234,19 +232,15 @@ class
HoodieMergeOnReadSnapshotHadoopFsRelationFactory(override val sqlContext:
override def buildFileIndex(): FileIndex = fileIndex
override def buildFileFormat(): FileFormat = {
- if (fileGroupReaderEnabled) {
- new HoodieFileGroupReaderBasedParquetFileFormat(
- tableState, HoodieTableSchema(tableStructSchema,
tableAvroSchema.toString, internalSchemaOpt),
- metaClient.getTableConfig.getTableName, mergeType, mandatoryFields,
- true, isBootstrap, false, shouldUseRecordPosition, Seq.empty)
- } else if (metaClient.getTableConfig.isMultipleBaseFileFormatsEnabled &&
!isBootstrap) {
+ if (metaClient.getTableConfig.isMultipleBaseFileFormatsEnabled &&
!isBootstrap) {
new
HoodieMultipleBaseFileFormat(sparkSession.sparkContext.broadcast(tableState),
sparkSession.sparkContext.broadcast(HoodieTableSchema(tableStructSchema,
tableAvroSchema.toString, internalSchemaOpt)),
metaClient.getTableConfig.getTableName, mergeType, mandatoryFields,
true, false, Seq.empty)
} else {
- new
NewHoodieParquetFileFormat(sparkSession.sparkContext.broadcast(tableState),
-
sparkSession.sparkContext.broadcast(HoodieTableSchema(tableStructSchema,
tableAvroSchema.toString, internalSchemaOpt)),
- metaClient.getTableConfig.getTableName, mergeType, mandatoryFields,
true, isBootstrap, false, Seq.empty)
+ new HoodieFileGroupReaderBasedParquetFileFormat(
Review Comment:
nit: Can we create a builder to build the file format instance? It's hard
to map which values are for what, especially for the booleans.
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala:
##########
@@ -259,65 +256,43 @@ object DefaultSource {
CDCRelation.getCDCRelation(sqlContext, metaClient, parameters)
}
} else {
- lazy val fileFormatUtils = if ((isMultipleBaseFileFormatsEnabled &&
!isBootstrappedTable)
- || (useNewParquetFileFormat)) {
- val formatUtils = new HoodieSparkFileFormatUtils(sqlContext,
metaClient, parameters, userSchema)
- if (formatUtils.hasSchemaOnRead) Option.empty else Some(formatUtils)
- } else {
- Option.empty
- }
-
- if (isMultipleBaseFileFormatsEnabled) {
- if (isBootstrappedTable) {
- throw new HoodieException(s"Multiple base file formats are not
supported for bootstrapped table")
- }
- resolveMultiFileFormatRelation(tableType, queryType,
fileFormatUtils.get)
Review Comment:
How do we support multiple base file formats now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
