danny0405 commented on code in PR #10326:
URL: https://github.com/apache/hudi/pull/10326#discussion_r1426608754
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieTimeline.java:
##########
@@ -246,6 +257,19 @@ public interface HoodieTimeline extends Serializable {
*/
HoodieTimeline findInstantsInClosedRange(String startTs, String endTs);
+ /**
+ * Create a new Timeline with instants after or equals startTs and before or
on endTs
+ * by completionTime.
+ */
+ HoodieTimeline findInstantsInClosedRangeByCompletionTime(String startTs,
String endTs);
+
Review Comment:
> this pr tries to read partial files in one commit,
Not sure we should, the basic granuarity for data compleness is a whole
`commit`
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieTimeline.java:
##########
@@ -246,6 +257,19 @@ public interface HoodieTimeline extends Serializable {
*/
HoodieTimeline findInstantsInClosedRange(String startTs, String endTs);
+ /**
+ * Create a new Timeline with instants after or equals startTs and before or
on endTs
+ * by completionTime.
+ */
+ HoodieTimeline findInstantsInClosedRangeByCompletionTime(String startTs,
String endTs);
+
Review Comment:
> this pr tries to read partial files in one commit,
Not sure we should do this, the basic granuarity for data compleness is a
whole `commit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
