the-other-tim-brown opened a new pull request, #10344:
URL: https://github.com/apache/hudi/pull/10344
### Change Logs
- The `ExternalSpillableMap` is now marked as `Closeable` as a reminder to
developers that it needs to be closed and so we can use try-with-resources with
this object
- Even when there was no data stored externally, the code would create an
external map for functions like `isEmpty` which will cause unnecessary overhead
and more cleanup when calling close. This change adds an "Empty" BitMap that
will be used if the BitMap is not yet initialized
- A few places were missing calls to close the map, so those are updated as
well. The shutdown hook will now log as well so any other places can more
easily be detected
### Impact
Avoids leaks from not closing the `ExternalSpillableMap` and optimize case
where all data for that map is currently in memory.
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the
risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature,
config, or user-facing change_
- _The config description must be updated if new configs are added or the
default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website.
Please create a Jira ticket, attach the
ticket number here and follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to
make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
