nsivabalan commented on code in PR #10342:
URL: https://github.com/apache/hudi/pull/10342#discussion_r1429238447
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -998,9 +996,9 @@ public void runMetaSync() {
* this constraint.
*/
private void setupWriteClient(Option<JavaRDD<HoodieRecord>> recordsOpt)
throws IOException {
- if ((null != schemaProvider)) {
+ if (null != schemaProvider) {
Schema sourceSchema = schemaProvider.getSourceSchema();
- Schema targetSchema = schemaProvider.getTargetSchema();
+ Schema targetSchema =
getSchemaForWriteConfig(schemaProvider.getTargetSchema());
Review Comment:
We do call.
```
reInitWriteClient {
final HoodieWriteConfig initialWriteConfig =
getHoodieClientConfig(targetSchema);
}
```
within getHoodieClientConfig, we do call
```
if (schema != null) {
builder.withSchema(getSchemaForWriteConfig(schema).toString());
}
```
but I agree, that if we had already called getSchemaForWriteConfig and fixed
the target schema, it will be no-op. Was just pointing out we are making
repeated calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
