danny0405 commented on code in PR #10308:
URL: https://github.com/apache/hudi/pull/10308#discussion_r1429432577
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -1092,6 +1092,10 @@ class HoodieSparkSqlWriterInternal {
&& mergedParams.getOrElse(DataSourceWriteOptions.TABLE_TYPE.key,
COPY_ON_WRITE.name) == MERGE_ON_READ.name) {
mergedParams.put(HoodieTableConfig.DROP_PARTITION_COLUMNS.key, "false")
}
+ // use meta sync database to fill hoodie.table.name if it not sets
+ if (!mergedParams.contains(HoodieTableConfig.DATABASE_NAME.key()) &&
mergedParams.contains(HoodieSyncConfig.META_SYNC_DATABASE_NAME.key())) {
Review Comment:
It looks like you are fixing the meta sync config, maybe just a UT for the
spark write config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
