codope commented on code in PR #10324:
URL: https://github.com/apache/hudi/pull/10324#discussion_r1429604793
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -179,6 +180,9 @@ private Schema generateRequiredSchema() {
for (String field :
recordMerger.getMandatoryFieldsForMerging(hoodieTableConfig)) {
if (requestedSchema.getField(field) == null) {
Option<Schema.Field> foundFieldOpt = findNestedField(dataSchema,
field);
+ if (!foundFieldOpt.isPresent()) {
+ foundFieldOpt = findMetaField(field);
Review Comment:
I think it's part of the record merger contract. One or more are needed to
decide the merge. It need not necessarily be `_hoodie_record_key`. See
https://github.com/apache/hudi/blob/50f0d9f3baeafe92c38dfb0b59b337d83391ea42/hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecordMerger.java#L129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
