hehuiyuan commented on code in PR #10388:
URL: https://github.com/apache/hudi/pull/10388#discussion_r1434755755
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSink.java:
##########
@@ -96,6 +96,8 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context
context) {
// Append mode
if (OptionsResolver.isAppendMode(conf)) {
+ // close compaction for append mode
+ conf.set(FlinkOptions.COMPACTION_SCHEDULE_ENABLED, false);
Review Comment:
Hi @danny0405 , if the table type is mor and the compaction.schedule.enabled
is true and the write.operation is append mode, the needsScheduleCompaction
returns true. But the compaction is useless
```
public static boolean isAppendMode(Configuration conf) {
// 1. inline clustering is supported for COW table;
// 2. async clustering is supported for both COW and MOR table
return isInsertOperation(conf) && ((isCowTable(conf) &&
!conf.getBoolean(FlinkOptions.INSERT_CLUSTER)) || isMorTable(conf));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
