linshan-ma commented on pull request #1880: URL: https://github.com/apache/hudi/pull/1880#issuecomment-664762563
> @linshan-ma Thanks for your contribution. Two suggestions: > > 1. It contains some irrelevant commits you should remove; > 2. Each PR must be completed and test-able before merging it into the codebase, otherwise, you can only provide a completed implementation. @yanghua Thank you for your advice。1 I checked.i will remove irrelevant code 2 I have tested the code ,Are you asking me to submit a test class? 3,the code is completed about build framework .The jiar [HUDI-1126] is other sub-task to Implement in detail ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
