danny0405 commented on code in PR #10426:
URL: https://github.com/apache/hudi/pull/10426#discussion_r1438950098
##########
hudi-common/src/main/java/org/apache/hudi/common/table/TableSchemaResolver.java:
##########
@@ -257,6 +259,8 @@ private Option<Schema>
getTableSchemaFromCommitMetadata(HoodieInstant instant, b
Schema schema = new Schema.Parser().parse(existingSchemaStr);
if (includeMetadataFields) {
schema = HoodieAvroUtils.addMetadataFields(schema,
hasOperationField.get());
+ } else {
+ schema = HoodieAvroUtils.removeMetadataFields(schema);
Review Comment:
In which case, the schema contains the metadata fields and we have to remove
explicitly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
