danny0405 commented on code in PR #10255:
URL: https://github.com/apache/hudi/pull/10255#discussion_r1442460176
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -135,44 +127,37 @@ public static Builder builder() {
public Result inputSplits(
HoodieTableMetaClient metaClient,
boolean cdcEnabled) {
- HoodieTimeline commitTimeline = getReadTimeline(metaClient);
- if (commitTimeline.empty()) {
- LOG.warn("No splits found for the table under path " + path);
+
+ IncrementalQueryAnalyzer analyzer = IncrementalQueryAnalyzer.builder()
+ .metaClient(metaClient)
+ .startTime(this.conf.getString(FlinkOptions.READ_START_COMMIT))
+ .endTime(this.conf.getString(FlinkOptions.READ_END_COMMIT))
Review Comment:
In streaming query, the user may declares nothing. And similar with Kafka,
it consumes from the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
