voonhous commented on code in PR #10457:
URL: https://github.com/apache/hudi/pull/10457#discussion_r1444419915
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroFileWriterFactory.java:
##########
@@ -51,7 +51,7 @@ protected HoodieFileWriter newParquetFileWriter(
String instantTime, Path path, Configuration conf, HoodieConfig config,
Schema schema,
TaskContextSupplier taskContextSupplier) throws IOException {
boolean populateMetaFields =
config.getBooleanOrDefault(HoodieTableConfig.POPULATE_META_FIELDS);
- boolean enableBloomFilter = populateMetaFields;
+ boolean enableBloomFilter = populateMetaFields &&
config.getBooleanOrDefault(HoodieStorageConfig.PARQUET_WITH_BLOOM_FILTER_ENABLED);
Review Comment:
Possible to add a check here to ensure that user is not using Bloom Index
too?
Maybe put it into a function so that it is visible/can be used for UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
