bvaradar commented on code in PR #10384:
URL: https://github.com/apache/hudi/pull/10384#discussion_r1445146024
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/SourceFormatAdapter.java:
##########
@@ -158,8 +160,9 @@ public InputBatch<JavaRDD<GenericRecord>>
fetchNewDataInAvroFormat(Option<String
}
case ROW: {
//we do the sanitizing here if enabled
- InputBatch<Dataset<Row>> r = ((Source<Dataset<Row>>)
source).fetchNext(lastCkptStr, sourceLimit);
- return new InputBatch<>(Option.ofNullable(r.getBatch().map(
+ // InputBatch<Dataset<Row>> r = ((Source<Dataset<Row>>)
source).fetchNext(lastCkptStr, sourceLimit);
+ List<InputBatch<Dataset<Row>>> rs = ((Source<Dataset<Row>>)
source).fetchNextForParitialUpdate(lastCkptStr, sourceLimit);
Review Comment:
Can you keep fetchNext as the main API to be called. Processing
PartialUpdate or fullUpdate needs to be encapsulated inside the Source
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
