yihua commented on a change in pull request #1149:
URL: https://github.com/apache/hudi/pull/1149#discussion_r463442771



##########
File path: 
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestDataGenerator.java
##########
@@ -161,6 +161,17 @@ public static void writePartitionMetadata(FileSystem fs, 
String[] partitionPaths
     }
   }
 
+  public static List<HoodieRecord> newHoodieRecords(int n, String time) throws 
Exception {

Review comment:
       After some investigation, I found that tests in 
`TestCopyOnWriteActionExecutor` use a different record schema, causing the bulk 
insert to fail using records from `HoodieTestDataGenerator::generateInserts`.  
For the bulk insert tests, I use the same schema provided by 
`HoodieTestDataGenerator` and `generateInserts()` for generating the testing 
records.  Now the tests work.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to