yihua commented on code in PR #10501:
URL: https://github.com/apache/hudi/pull/10501#discussion_r1453879111
##########
hudi-common/src/main/java/org/apache/hudi/common/util/ClusteringUtils.java:
##########
@@ -82,12 +82,12 @@ public static boolean
isClusteringCommit(HoodieTableMetaClient metaClient, Hoodi
/**
* Get requested replace metadata from timeline.
- * @param metaClient
+ * @param timeline
Review Comment:
nit: along changes to the parameters, add docs to improve the readability.
##########
hudi-common/src/main/java/org/apache/hudi/common/util/ClusteringUtils.java:
##########
@@ -112,8 +112,18 @@ private static Option<HoodieRequestedReplaceMetadata>
getRequestedReplaceMetadat
* @return
*/
public static Option<Pair<HoodieInstant, HoodieClusteringPlan>>
getClusteringPlan(HoodieTableMetaClient metaClient, HoodieInstant
pendingReplaceInstant) {
+ return getClusteringPlan(metaClient.getActiveTimeline(),
pendingReplaceInstant);
+ }
+
+ /**
+ * Get Clustering plan from timeline.
+ * @param timeline
Review Comment:
Similar here for docs on parameters and return value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
