danny0405 commented on code in PR #10505:
URL: https://github.com/apache/hudi/pull/10505#discussion_r1454399288
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -111,7 +111,7 @@ public class Pipelines {
*/
public static DataStreamSink<Object> bulkInsert(Configuration conf, RowType
rowType, DataStream<RowData> dataStream) {
WriteOperatorFactory<RowData> operatorFactory =
BulkInsertWriteOperator.getFactory(conf, rowType);
- if (OptionsResolver.isBucketIndexType(conf)) {
+ if (!OptionsResolver.isAppendMode(conf) &&
OptionsResolver.isBucketIndexType(conf)) {
Review Comment:
In `HoodieTableSink`, the append mode has the first priority, that means an
append only table would never take the bucket index into effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]