nsivabalan commented on code in PR #10520:
URL: https://github.com/apache/hudi/pull/10520#discussion_r1456675246
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala:
##########
@@ -138,17 +138,22 @@ class DefaultSource extends RelationProvider
mode: SaveMode,
optParams: Map[String, String],
df: DataFrame): BaseRelation = {
- if (optParams.get(OPERATION.key).contains(BOOTSTRAP_OPERATION_OPT_VAL)) {
- HoodieSparkSqlWriter.bootstrap(sqlContext, mode, optParams, df)
- HoodieSparkSqlWriter.cleanup()
- } else {
- val (success, _, _, _, _, _) = HoodieSparkSqlWriter.write(sqlContext,
mode, optParams, df)
- HoodieSparkSqlWriter.cleanup()
- if (!success) {
- throw new HoodieException("Write to Hudi failed")
+ var shouldThrow = false
+ try {
+ if (optParams.get(OPERATION.key).contains(BOOTSTRAP_OPERATION_OPT_VAL)) {
Review Comment:
can we keep the code block as is. just add a try finally. and clean up
within finally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
