danny0405 commented on code in PR #10518:
URL: https://github.com/apache/hudi/pull/10518#discussion_r1456782018
##########
hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/execution/datasources/Spark3ParsePartitionUtil.scala:
##########
@@ -274,6 +274,8 @@ object Spark3ParsePartitionUtil extends
SparkParsePartitionUtil {
}.getOrElse {
Cast(Cast(Literal(value), DateType, Some(zoneId.getId)), dt).eval()
}
+ case BinaryType => value.getBytes()
+ case BooleanType => value.toBoolean
case dt => throw new IllegalArgumentException(s"Unexpected type $dt")
}
Review Comment:
Looks good, can we write a UT for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
