paul8263 commented on code in PR #10517:
URL: https://github.com/apache/hudi/pull/10517#discussion_r1457191018
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/ExpressionPredicates.java:
##########
@@ -602,10 +602,10 @@ private static FilterPredicate
toParquetPredicate(FunctionDefinition functionDef
case TINYINT:
case SMALLINT:
case INTEGER:
+ case DATE:
case TIME_WITHOUT_TIME_ZONE:
return predicateSupportsLtGt(functionDefinition,
intColumn(columnName), (Integer) literal);
case BIGINT:
- case DATE:
case TIMESTAMP_WITHOUT_TIME_ZONE:
Review Comment:
Hi @danny0405 ,
As far as I could see there should be no exceptions thrown here. I have gone
through all TPCDS queries. They could work well with all patches applied that I
sumbitted recently.
If there might be some potential risks for this change, please let me know.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
