xuzifu666 commented on code in PR #10541:
URL: https://github.com/apache/hudi/pull/10541#discussion_r1461296888
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java:
##########
@@ -176,13 +177,24 @@ public Set<ConfigOption<?>> optionalOptions() {
*/
private void sanityCheck(Configuration conf, ResolvedSchema schema) {
checkTableType(conf);
+ checkIndexType(conf);
if (!OptionsResolver.isAppendMode(conf)) {
checkRecordKey(conf, schema);
}
StreamerUtil.checkPreCombineKey(conf, schema.getColumnNames());
}
+ /**
+ * Validate the index type.
+ */
+ private void checkIndexType(Configuration conf) {
+ String indexType = conf.get(FlinkOptions.INDEX_TYPE);
+ if (!StringUtils.isNullOrEmpty(indexType)) {
+ HoodieIndexConfig.INDEX_TYPE.checkValues(indexType);
Review Comment:
For example，user create table in Flink Engine such like set
index.type='BUCK'，engine not error out until write data into table. So error
out when set table schema before user write is kind. @danny0405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
