bvaradar commented on code in PR #10489:
URL: https://github.com/apache/hudi/pull/10489#discussion_r1462356868
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -448,6 +448,7 @@ private List<MergeOnReadInputSplit> getInputSplits(
final String mergeType = this.conf.getString(FlinkOptions.MERGE_TYPE);
return readPartitions.stream()
.map(relPartitionPath -> getFileSlices(fsView, relPartitionPath,
maxQueryInstantTime, skipBaseFiles)
+ .sorted((Comparator.comparing(FileSlice::getBaseInstantTime)))
Review Comment:
@empcl : Since we are sorting by getLastCommit() at the end of this
processing step, wouldn't it defeat the purpose of ordering by base Instant
time ?
Can you also write a simple unit-test to verify the expected order ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
