danny0405 commented on code in PR #10531:
URL: https://github.com/apache/hudi/pull/10531#discussion_r1463132247
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/ExpressionPredicates.java:
##########
@@ -223,7 +228,98 @@ public ColumnPredicate
bindValueLiteral(ValueLiteralExpression valueLiteral) {
@Override
public FilterPredicate filter() {
- return toParquetPredicate(getFunctionDefinition(), literalType,
columnName, literal);
+ Serializable convertedLiteral = convertImplicitly(literalType, literal);
+ return toParquetPredicate(getFunctionDefinition(), literalType,
columnName, convertedLiteral);
+ }
+
+ private Serializable convertImplicitly(LogicalType literalType,
Serializable literal) {
+ try {
Review Comment:
Implicit type conversion is a intricate topic, I would suggest we move this
logic into a separate class `ImplicitTypeConversions` first, when Flink
supports that, we can deprecate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
