nsivabalan commented on code in PR #10238:
URL: https://github.com/apache/hudi/pull/10238#discussion_r1465848613
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -652,7 +653,7 @@ public static HoodieData<HoodieRecord>
convertMetadataToColumnStatsRecords(Hoodi
String partitionPath = deleteFileInfoPair.getLeft();
String filePath = deleteFileInfoPair.getRight();
- if (filePath.endsWith(HoodieFileFormat.PARQUET.getFileExtension())) {
+ if (filePath.endsWith(HoodieFileFormat.PARQUET.getFileExtension())
|| ExternalFilePathUtil.isExternallyCreatedFile(filePath)) {
Review Comment:
I guess there is some gap here wrt log files.
for log files, we get stats directly from Append Handle and entries are
added to col stats using log file name.
so, during clean commit metadata, we should be deleting both data files and
log files.
https://issues.apache.org/jira/browse/HUDI-7331
I have created a follow up ticket on this. lets fix it thoroughly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
