xushiyan commented on a change in pull request #1897:
URL: https://github.com/apache/hudi/pull/1897#discussion_r464177006
##########
File path: scripts/run_travis_tests.sh
##########
@@ -22,7 +22,7 @@ sparkVersion=2.4.4
hadoopVersion=2.7
if [ "$mode" = "unit" ]; then
- mvn clean install -Punit-tests -DskipTests -q
+ mvn clean install -DskipTests -q
Review comment:
sure. the "unit-tests" maven profile sets `skipUTs=false`, which will
cause scalatest-maven-plugin to run tests during the install phase. I actually
don't recall why I have to set maven profile here.. 🤔
##########
File path: scripts/run_travis_tests.sh
##########
@@ -22,7 +22,7 @@ sparkVersion=2.4.4
hadoopVersion=2.7
if [ "$mode" = "unit" ]; then
- mvn clean install -Punit-tests -DskipTests -q
+ mvn clean install -DskipTests -q
Review comment:
sure. the "unit-tests" maven profile sets `skipUTs=false`, which will
cause scalatest-maven-plugin to run tests during the install phase. I actually
don't recall why I have to set maven profile here..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
