parisni commented on code in PR #10572:
URL: https://github.com/apache/hudi/pull/10572#discussion_r1468632782
##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -578,6 +578,14 @@ public Map<String, String> getMetastoreSchema(String
tableName) {
}
}
+ @Override
+ public List<FieldSchema> getMetastoreFieldSchemas(String tableName) {
+ Map<String, String> schema = getMetastoreSchema(tableName);
+ return schema.entrySet().stream()
+ .map(f -> new FieldSchema(f.getKey(), f.getValue()))
+ .collect(Collectors.toList());
+ }
Review Comment:
it needs an integration tests with a glue endpoint. It might be possible
with moto. However it's a large task. I can work on it on an other PR. That
would make the aws module more stable i hope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
