kbuci commented on code in PR #10565:
URL: https://github.com/apache/hudi/pull/10565#discussion_r1470107376
##########
hudi-client/hudi-client-common/pom.xml:
##########
@@ -120,6 +120,16 @@
<groupId>io.prometheus</groupId>
<artifactId>simpleclient_pushgateway</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.uber.m3</groupId>
+ <artifactId>tally-m3</artifactId>
Review Comment:
I took a look at dependencies used by `com.uber.m3:tally-m3` and
`com.uber.m3:tally-core` . It seems that the former has dependency
`org.apache.thrift:libthrift:jar:0.9.3` and
`com.google.code.findbugs:jsr305:jar:3.0.2` .
I'll take a look at how to make sure `com.uber.m3:tally-core` uses its own
version of thrift and `com.google.code.findbugs` so that HUDI APIs (and other
dependencies) won't use in tally's versions and tally will use the versions it
needs, which I think I might need to use shading to solve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
