yihua commented on code in PR #10570:
URL: https://github.com/apache/hudi/pull/10570#discussion_r1470526275
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/ExportCommand.java:
##########
@@ -190,7 +191,7 @@ private int copyNonArchivedInstants(List<HoodieInstant>
instants, int limit, Str
final HoodieTableMetaClient metaClient = HoodieCLI.getTableMetaClient();
final HoodieActiveTimeline timeline = metaClient.getActiveTimeline();
for (HoodieInstant instant : instants) {
- String localPath = localFolder + Path.SEPARATOR + instant.getFileName();
+ String localPath = localFolder + HoodieLocation.SEPARATOR +
instant.getFileName();
Review Comment:
The [federated storage
layer](https://github.com/apache/hudi/blob/master/rfc/rfc-60/rfc-60.md) wants
to use this `HoodieLocation` for redirecting data files by adding a prefix so
there's the translation of logical and physical storage location.
`HoodieLocation` is still different from `HoodieRecordLocation` as it
represents file location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
