nsivabalan commented on a change in pull request #1868:
URL: https://github.com/apache/hudi/pull/1868#discussion_r464470637
##########
File path:
hudi-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java
##########
@@ -269,8 +267,8 @@ public void testUpsertPartitionerWithSmallInsertHandling()
throws Exception {
assertEquals(BucketType.INSERT, partitioner.getBucketInfo(3).bucketType,
"Bucket 3 is INSERT");
assertEquals(4, insertBuckets.size(), "Total of 4 insert buckets");
- assertEquals(0, insertBuckets.get(0).bucketNumber, "First insert bucket
must be same as update bucket");
- assertEquals(200.0 / 2400, insertBuckets.get(0).weight, 0.01, "First
insert bucket should have weight 0.5");
+ assertEquals(0, insertBuckets.get(0).getKey().bucketNumber, "First insert
bucket must be same as update bucket");
+ assertEquals(200.0 / 2400, insertBuckets.get(0).getKey().weight, 0.01,
"First insert bucket should have weight 0.5");
Review comment:
it is fine. Would you mind adding assertions for all buckets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
