codope commented on issue #10580: URL: https://github.com/apache/hudi/issues/10580#issuecomment-1919578705
Interesting. So, we had done a micro-benchmark and we found that there was about 5% slowness due to JOL. And since we already invoke this for only a sample of records and not all records in the batch, we did not consider other alternatives (as mentioned in the description of PR). The main reason it was added because Trino upgraded to Java 17 and trino-hudi connector build started failing (reason mentioned in the PR). I am curious if something else is going on because object size calculation lies on the hotpath, this issue would have surfaced in other large scale benchmarks that we run before release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
