[
https://issues.apache.org/jira/browse/HUDI-7372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lin Liu updated HUDI-7372:
--------------------------
Description: In current building process a thrift file is compiled on the
fly, where we run the thrift command using docker run command. Since GH CI runs
in containers, it means that we are utilizing a docker A to generate files in
docker B. I don't know if there are any risks or complexity there. I want to
propose that we run thrift command offline to generate the classes, and check
them into hudi repo. Then we can 1. reduce the complexity of the compiling
process; 2. reduce the compiling time in the CI tests, 3. remove the
requirement for installing thrift in our building environment. Meanwhile, I did
not see any benefits to build these classes on the fly.
> Remove thrift usage from building process
> -----------------------------------------
>
> Key: HUDI-7372
> URL: https://issues.apache.org/jira/browse/HUDI-7372
> Project: Apache Hudi
> Issue Type: Bug
> Reporter: Lin Liu
> Assignee: Lin Liu
> Priority: Major
>
> In current building process a thrift file is compiled on the fly, where we
> run the thrift command using docker run command. Since GH CI runs in
> containers, it means that we are utilizing a docker A to generate files in
> docker B. I don't know if there are any risks or complexity there. I want to
> propose that we run thrift command offline to generate the classes, and check
> them into hudi repo. Then we can 1. reduce the complexity of the compiling
> process; 2. reduce the compiling time in the CI tests, 3. remove the
> requirement for installing thrift in our building environment. Meanwhile, I
> did not see any benefits to build these classes on the fly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
