yihua commented on code in PR #10619:
URL: https://github.com/apache/hudi/pull/10619#discussion_r1485198693
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/compact/TestHoodieCompactor.java:
##########
@@ -298,9 +300,16 @@ private HoodieData<WriteStatus>
compact(SparkRDDWriteClient writeClient, String
* Verify that all partition paths are present in the WriteStatus result.
*/
private void verifyCompaction(HoodieData<WriteStatus> result) {
+ List<WriteStatus> writeStatuses = result.collectAsList();
for (String partitionPath : dataGen.getPartitionPaths()) {
- List<WriteStatus> writeStatuses = result.collectAsList();
assertTrue(writeStatuses.stream().anyMatch(writeStatus ->
writeStatus.getStat().getPartitionPath().contentEquals(partitionPath)));
}
+
+ writeStatuses.forEach(writeStatus -> {
+ final HoodieWriteStat.RuntimeStats stats =
writeStatus.getStat().getRuntimeStats();
+ assertNotNull(stats);
+ assertTrue(stats.getTotalUpsertTime() > 0);
+ assertTrue(stats.getTotalScanTime() > 0);
Review Comment:
Also assert `TotalCreateTime`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
