the-other-tim-brown commented on code in PR #10578:
URL: https://github.com/apache/hudi/pull/10578#discussion_r1486462103
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieKeyLookupHandle.java:
##########
@@ -46,13 +48,13 @@ public class HoodieKeyLookupHandle<T, I, K, O> extends
HoodieReadHandle<T, I, K,
private static final Logger LOG =
LoggerFactory.getLogger(HoodieKeyLookupHandle.class);
private final BloomFilter bloomFilter;
- private final List<String> candidateRecordKeys;
+ private final Set<String> candidateRecordKeys;
private long totalKeysChecked;
public HoodieKeyLookupHandle(HoodieWriteConfig config, HoodieTable<T, I, K,
O> hoodieTable,
Pair<String, String> partitionPathFileIDPair) {
super(config, hoodieTable, partitionPathFileIDPair);
- this.candidateRecordKeys = new ArrayList<>();
+ this.candidateRecordKeys = new HashSet<>();
Review Comment:
This set is passed in to `filterKeysFromFile` which used to take this list
and immediately convert to a set so I have updated this to be a set from the
start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
