bvaradar commented on PR #10693: URL: https://github.com/apache/hudi/pull/10693#issuecomment-1951639104
> @bvaradar Hi, I'm new to hudi and I try to make some contribution to hudi. Maybe what I said is not correct. This may be just a personal coding habit, because there is no else branch, but the code of the if branch is too long, so I made adjustments. If you think it doesn't make much sense, it doesn't matter. @zhuyaogai : Thanks for the explanation. Welcome to Hudi community. Looking forward to many more contributions from you. Regarding this diff, I do not see any issue with this change as we have examples of both preferences. Once the test succeeds, will land this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
