nsivabalan commented on code in PR #10694:
URL: https://github.com/apache/hudi/pull/10694#discussion_r1495952825
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java:
##########
@@ -210,8 +211,13 @@ Dataset<Row> applyFilter(Dataset<Row> source, String
fileFormat) {
if (!StringUtils.isNullOrEmpty(getStringWithAltKeys(props,
S3_IGNORE_KEY_SUBSTRING, true))) {
filter = filter + " and " + S3_OBJECT_KEY + " not like '%" +
getStringWithAltKeys(props, S3_IGNORE_KEY_SUBSTRING) + "%'";
}
- // add file format filtering by default
- filter = filter + " and " + S3_OBJECT_KEY + " like '%" + fileFormat + "%'";
+ // Match files with a given extension, or use the fileFormat as the
fallback incase the config is not set.
+ if (!StringUtils.isNullOrEmpty(getStringWithAltKeys(props,
CLOUD_DATAFILE_EXTENSION, true))) {
Review Comment:
can we consider moving this to common class and use it across both s3 and
gcs ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
