bvaradar commented on a change in pull request #1752: URL: https://github.com/apache/hudi/pull/1752#discussion_r465333562
########## File path: hudi-client/src/main/java/org/apache/hudi/async/AsyncCompactService.java ########## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.async; + +import org.apache.hudi.client.Compactor; +import org.apache.hudi.client.HoodieWriteClient; +import org.apache.hudi.common.table.timeline.HoodieInstant; +import org.apache.hudi.common.util.collection.Pair; +import org.apache.hudi.exception.HoodieIOException; +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; +import org.apache.spark.api.java.JavaSparkContext; + +import java.io.IOException; +import java.util.concurrent.BlockingQueue; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.LinkedBlockingQueue; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.locks.Condition; +import java.util.concurrent.locks.ReentrantLock; +import java.util.stream.IntStream; + +/** + * Async Compactor Service that runs in separate thread. Currently, only one compactor is allowed to run at any time. + */ +public class AsyncCompactService extends AbstractAsyncService { + + private static final long serialVersionUID = 1L; + private static final Logger LOG = LogManager.getLogger(AsyncCompactService.class); + + /** + * This is the job pool used by async compaction. + * In case of deltastreamer, Spark job scheduling configs are automatically set. + * As the configs needs to be set before spark context is initiated, it is not + * automated for Structured Streaming. + * https://spark.apache.org/docs/latest/job-scheduling.html + */ + public static final String COMPACT_POOL_NAME = "hoodiecompact"; + + private final int maxConcurrentCompaction; + private transient Compactor compactor; + private transient JavaSparkContext jssc; + private transient BlockingQueue<HoodieInstant> pendingCompactions = new LinkedBlockingQueue<>(); + private transient ReentrantLock queueLock = new ReentrantLock(); + private transient Condition consumed = queueLock.newCondition(); + + public AsyncCompactService(JavaSparkContext jssc, HoodieWriteClient client) { + this.jssc = jssc; + this.compactor = new Compactor(client, jssc); + this.maxConcurrentCompaction = 1; + } + + /** + * Enqueues new Pending compaction. + */ + public void enqueuePendingCompaction(HoodieInstant instant) { + pendingCompactions.add(instant); + } + + /** + * Wait till outstanding pending compactions reduces to the passed in value. + * + * @param numPendingCompactions Maximum pending compactions allowed + * @throws InterruptedException + */ + public void waitTillPendingCompactionsReducesTo(int numPendingCompactions) throws InterruptedException { + try { + queueLock.lock(); + while (!isShutdown() && (pendingCompactions.size() > numPendingCompactions)) { + consumed.await(); + } + } finally { + queueLock.unlock(); + } + } + + /** + * Fetch Next pending compaction if available. + * + * @return + * @throws InterruptedException + */ + private HoodieInstant fetchNextCompactionInstant() throws InterruptedException { + LOG.info("Compactor waiting for next instant for compaction upto 60 seconds"); + HoodieInstant instant = pendingCompactions.poll(10, TimeUnit.SECONDS); + if (instant != null) { + try { + queueLock.lock(); + // Signal waiting thread + consumed.signal(); + } finally { + queueLock.unlock(); + } + } + return instant; + } + + /** + * Start Compaction Service. + */ + @Override + protected Pair<CompletableFuture, ExecutorService> startService() { + ExecutorService executor = Executors.newFixedThreadPool(maxConcurrentCompaction, + r -> new Thread(r, "async_compact_thread")); + return Pair.of(CompletableFuture.allOf(IntStream.range(0, maxConcurrentCompaction).mapToObj(i -> CompletableFuture.supplyAsync(() -> { + try { + // Set Compactor Pool Name for allowing users to prioritize compaction + LOG.info("Setting Spark Pool name for compaction to " + COMPACT_POOL_NAME); + jssc.setLocalProperty("spark.scheduler.pool", COMPACT_POOL_NAME); + + while (!isShutdownRequested()) { + final HoodieInstant instant = fetchNextCompactionInstant(); + + if (null != instant) { + LOG.info("Starting Compaction for instant " + instant); + compactor.compact(instant); + LOG.info("Finished Compaction for instant " + instant); + } + + if (shouldStopCompactor()) { + return true; + } + } + LOG.info("Compactor shutting down properly!!"); + } catch (InterruptedException ie) { + LOG.warn("Compactor executor thread got interrupted exception. Stopping", ie); + } catch (IOException e) { + LOG.error("Compactor executor failed", e); + throw new HoodieIOException(e.getMessage(), e); + } + return true; + }, executor)).toArray(CompletableFuture[]::new)), executor); + } + + /** + * Spark Structured Streaming Sink implementation do not have mechanism to know when the stream is shutdown. Review comment: Done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
