boneanxs commented on PR #10714: URL: https://github.com/apache/hudi/pull/10714#issuecomment-1960641014
> @boneanxs Can you help for the review and clarify the initiative aim of the task? Hey @danny0405 @wombatu-kun, sorry for misunderstanding. The intention of this issue is to moving `createNewInstantTime` to `TimeGenerator` or somewhere else as a instance method since `createNewInstantTime` in `HoodieActiveTimeline` is a static method and requires to pass `HadoopConf` and `HoodieTimeGeneratorConfig`(now is `TimeGenerator`) every time. But after some codes refine of #9617(we hide `createNewInstantTime` to `HoodieTableMetaClient` and `BaseHoodieClient`), it looks quite clean now, not sure we still need this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
