danny0405 commented on code in PR #10715:
URL: https://github.com/apache/hudi/pull/10715#discussion_r1501963827
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/internal/DataSourceInternalWriterHelper.java:
##########
@@ -66,13 +66,11 @@ public DataSourceInternalWriterHelper(String instantTime,
HoodieWriteConfig writ
this.extraMetadata = extraMetadata;
this.writeClient = new SparkRDDWriteClient<>(new
HoodieSparkEngineContext(new JavaSparkContext(sparkSession.sparkContext())),
writeConfig);
this.writeClient.setOperationType(operationType);
- this.writeClient.startCommitWithTime(instantTime);
this.writeClient.initTable(operationType, Option.of(instantTime));
Review Comment:
I have no strong advices in this moment, the lifecycle methods in write
client has it's own dependencies, this is really a pain to maintainence, maybe
we should add more docs for them first and find out a way to make the method
invocation more safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
