zhedoubushishi commented on a change in pull request #1869: URL: https://github.com/apache/hudi/pull/1869#discussion_r465457434
########## File path: hudi-cli/src/test/java/org/apache/hudi/cli/integ/ITTestBootstrapCommand.java ########## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.cli.integ; + +import org.apache.hudi.cli.HoodieCLI; +import org.apache.hudi.cli.HoodiePrintHelper; +import org.apache.hudi.cli.commands.TableCommand; +import org.apache.hudi.cli.testutils.AbstractShellIntegrationTest; +import org.apache.hudi.common.model.HoodieTableType; +import org.apache.hudi.common.table.timeline.versioning.TimelineLayoutVersion; +import org.apache.hudi.testutils.HoodieTestDataGenerator; + +import org.apache.spark.sql.Dataset; +import org.apache.spark.sql.Row; +import org.apache.spark.sql.SaveMode; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.springframework.shell.core.CommandResult; + +import java.io.File; +import java.io.IOException; +import java.time.Instant; +import java.util.Arrays; +import java.util.List; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * Test class of {@link org.apache.hudi.cli.commands.BootstrapCommand}. + */ +public class ITTestBootstrapCommand extends AbstractShellIntegrationTest { + + private static final int TOTAL_RECORDS = 100; + private static final String PARTITION_FIELD = "datestr"; + private static final String RECORD_KEY_FIELD = "_row_key"; + + private String sourcePath; + private String tablePath; + private List<String> partitions; + + @BeforeEach + public void init() throws IOException { + String srcName = "source"; + String tableName = "test-table"; + sourcePath = basePath + File.separator + srcName; + tablePath = basePath + File.separator + tableName; + + partitions = Arrays.asList("2018", "2019", "2020"); + double timestamp = new Double(Instant.now().toEpochMilli()).longValue(); + Dataset<Row> df = HoodieTestDataGenerator.generateTestRawTripDataset(timestamp, + TOTAL_RECORDS, partitions, jsc, sqlContext); + df.write().partitionBy("datestr").format("parquet").mode(SaveMode.Overwrite).save(sourcePath); + + // Create table and connect + new TableCommand().createTable( + tablePath, tableName, HoodieTableType.COPY_ON_WRITE.name(), + "", TimelineLayoutVersion.VERSION_1, "org.apache.hudi.common.model.HoodieAvroPayload", + "org.apache.hudi.common.bootstrap.index.HFileBasedBootstrapIndex"); + } + + /** + * Test case for command 'bootstrap'. + */ + @Test + public void testBootstrapRunCommand() throws IOException { + // test bootstrap run command + String cmdStr = String.format("bootstrap run --sourcePath %s --recordKeyColumns %s --partitionFields %s --sparkMaster %s", + sourcePath, RECORD_KEY_FIELD, PARTITION_FIELD, "local"); + CommandResult cr = getShell().executeCommand(cmdStr); + assertTrue(cr.isSuccess()); + + // Check hudi table exist + new TableCommand().connect(tablePath, TimelineLayoutVersion.VERSION_1, false, 2000, 300000, 7); + metaClient = HoodieCLI.getTableMetaClient(); + assertEquals(1, metaClient.getActiveTimeline().getCommitsTimeline().countInstants(), "Should have 1 commit."); + + // test bootstrap show indexed partitions Review comment: Added another two test cases for ```bootstrap index showMapping```. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
