stream2000 commented on code in PR #10776:
URL: https://github.com/apache/hudi/pull/10776#discussion_r1506906419
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/CreateHoodieTableCommand.scala:
##########
@@ -146,11 +146,12 @@ object CreateHoodieTableCommand {
val partitionColumnNames = hoodieCatalogTable.partitionSchema.map(_.name)
// Remove some properties should not be used;append pk, preCombineKey,
type to the properties of table
val newTblProperties =
- hoodieCatalogTable.catalogProperties.--(needFilterProps) ++
HoodieOptionConfig.extractSqlOptions(properties)
+ hoodieCatalogTable.catalogProperties.--(needFilterProps) + ("provider"
-> "hudi") ++ HoodieOptionConfig.extractSqlOptions(properties)
Review Comment:
Thanks for your contribution! Let's create a JIRA ticket to track this fix.
Additionally, it would be valuable to implement a test that verifies all tables
created by Hudi have the correct configuration settings applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
