yihua commented on code in PR #10679:
URL: https://github.com/apache/hudi/pull/10679#discussion_r1508541594
##########
website/docs/gcp_bigquery.md:
##########
@@ -39,8 +39,9 @@ setting sync tool class. A few BigQuery-specific
configurations are required.
| `hoodie.gcp.bigquery.sync.dataset_location` | Region info of the dataset;
same as the GCS bucket that stores the Hudi table
|
| `hoodie.gcp.bigquery.sync.source_uri` | A wildcard path pattern
pointing to the first level partition; partition key can be specified or
auto-inferred. Only required for partitioned tables |
| `hoodie.gcp.bigquery.sync.source_uri_prefix` | The common prefix of the
`source_uri`, usually it's the path to the Hudi table, trailing slash does not
matter. |
-| `hoodie.gcp.bigquery.sync.base_path` | The usual basepath config for
Hudi table.
|
| `hoodie.gcp.bigquery.sync.use_bq_manifest_file` | Set to true to enable the
manifest based sync
|
+| `hoodie.gcp.bigquery.sync.require_partition_filter` | Introduced in Hudi
version 0.14.1, this configuration accepts a BOOLEAN value, with the default
being false. When enabled (set to true), you must create a predicate filter (a
WHERE clause) for all queries, targeting the partitioning column of a
partitioned table. Queries lacking such a predicate filter will result in an
error. |
Review Comment:
```suggestion
| `hoodie.gcp.bigquery.sync.require_partition_filter` | Introduced in Hudi
version 0.14.1, this configuration accepts a BOOLEAN value, with the default
being false. When enabled (set to true), you must create a partition filter (a
WHERE clause) for all queries, targeting the partitioning column of a
partitioned table. Queries lacking such a filter will result in an error.
|
```
##########
website/docs/gcp_bigquery.md:
##########
@@ -39,8 +39,9 @@ setting sync tool class. A few BigQuery-specific
configurations are required.
| `hoodie.gcp.bigquery.sync.dataset_location` | Region info of the dataset;
same as the GCS bucket that stores the Hudi table
|
| `hoodie.gcp.bigquery.sync.source_uri` | A wildcard path pattern
pointing to the first level partition; partition key can be specified or
auto-inferred. Only required for partitioned tables |
| `hoodie.gcp.bigquery.sync.source_uri_prefix` | The common prefix of the
`source_uri`, usually it's the path to the Hudi table, trailing slash does not
matter. |
-| `hoodie.gcp.bigquery.sync.base_path` | The usual basepath config for
Hudi table.
|
Review Comment:
I suggest keeping this as it is still in the code base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
